Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: configure i18n.ally plugin #1277

Merged
merged 2 commits into from
Apr 10, 2024
Merged

chore: configure i18n.ally plugin #1277

merged 2 commits into from
Apr 10, 2024

Conversation

ipcjs
Copy link
Contributor

@ipcjs ipcjs commented Apr 5, 2024 •
edited by micahmo
Loading

Pull Request Description

Configuration i18n.ally plugin, support writing the multi-language characters in the form of l10n.key

Issue Being Fixed

Close ipcjs/i18n-ally#3

Screenshots / Recordings

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

micahmo
micahmo approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had no idea we could configure our own usageMatch and templates! That, of course, makes much more sense than baking this into the extension.

This works like a charm, thank you so much!

Code_kyHnJgbIBx.mp4

@ipcjs
Copy link
Contributor Author

ipcjs commented Apr 5, 2024

I just realized that they are configurable after browsing the code😂

@hjiangsu hjiangsu merged commit 9a0b037 into thunder-app:develop Apr 10, 2024
1 check passed
@micahmo micahmo mentioned this pull request Apr 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micahmo micahmo micahmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ipcjs @micahmo @hjiangsu