Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sort to instance explorer #1317

Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Apr 18, 2024

Pull Request Description

The PR adds the ability to sort entities in the instance explorer. The "open in browser" button now becomes a sort button when in any section other than "About".

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

qemu-system-x86_64_XI6f1WOMJ4.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@micahmo
Copy link
Member Author

micahmo commented Apr 25, 2024

Note: This may go away if we implement something more like what's suggested here.

@hjiangsu
Copy link
Member

hjiangsu commented May 1, 2024

Placing this on hold since we're leaning in the direction of switching Search to Explore!

@hjiangsu hjiangsu added the on-hold Issue that requires more information or reproducible steps label May 1, 2024
@micahmo
Copy link
Member Author

micahmo commented May 21, 2024

As with my comment here, how would we feel about merging this PR? Even if we abandon the existing search/explore page, that will probably take a while, so this feature would be nice to have in the short term. And the change itself is relatively small. 😊

@hjiangsu hjiangsu merged commit a277c92 into thunder-app:develop May 24, 2024
1 check passed
@micahmo micahmo deleted the feature/instance-explorer-sort branch May 24, 2024 03:30
@micahmo micahmo removed the on-hold Issue that requires more information or reproducible steps label Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants