Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notification debugging section #1343

Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented May 2, 2024

Pull Request Description

This PR adds a new section to the Debug page that can help us to troubleshoot issues with notifications.

Status

  • It will display the currently selected notification mode.
  • It will display whether notifications are allowed by the OS.
  • It will display the connected UnifiedPush app (if any) and how many are available.
  • There is a link to and from the general notification settings.

Testing

  • When in local notifications mode, there is an option to send a test notification, both while the app is running, and also to queue up a background notification and kill the app.
  • When in UnifiedPush mode, there is an option to request that the server send us a notification while the app is running, and an option to ask the notification server to send us a delayed notification and kill the app. The implementation for these settings is not yet there, as the server doesn't have corresponding endpoints. But these options are also hidden behind an experimental flag for now anyway.

All of these things should be extendable to the iOS side as well!

Screenshots / Recordings

Note: The local background notification takes about 2 minutes to arrive, so you may wish to fast-forward to 2:43 at that point. 😊

qemu-system-x86_64_dctpBbMovD.mp4

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! As mentioned in #1335, I'm fast-tracking notification PRs to help with troubleshooting/fixing the issues with notifications. As such, I've only taken a brief look over the changes 😅

@hjiangsu hjiangsu merged commit 280a80f into thunder-app:develop May 6, 2024
1 check passed
@micahmo micahmo deleted the feature/notification-debugging branch May 6, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants