Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix partial comment navigation #1366

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

hjiangsu
Copy link
Member

Pull Request Description

This PR adds some additional logic that attempts to take into account the user's currently visible comments, and perform comment navigation based on the visible contents. I also increased the animation duration since it felt a bit too quick in the previous implementation!

When the user has partially navigated down, tapping on the next comment will bring them to the next comment. Likewise, tapping on the previous comment will bring the user up to the current comment (if it is partially obscured). If the current comment is not partially obscured, it will bring the user to the previous comment.

Navigating down:

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-05-14.at.20.46.01.mp4

Navigating up:

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-05-14.at.21.03.35.mp4

Note: There is currently an issue where if you tap the up comment nav while you're in a partially obscure comment, and repeat the action with the same comment, it goes up twice. Here's a video showing the issue:

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-05-14.at.21.19.04.mp4

I haven't found an easy way to fix this yet, so if you have any ideas, please let me know!

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find, thank you so much for fixing this!!

@hjiangsu
Copy link
Member Author

Note: There is currently an issue where if you tap the up comment nav while you're in a partially obscure comment, and repeat the action with the same comment, it goes up twice.

I'll go ahead and merge this in first, and work on this issue at a later time (I don't believe it's a big deal because this situation shouldn't happen too often, and can be fixed by tapping on the next comment button)

@hjiangsu hjiangsu merged commit 4c8c034 into develop May 15, 2024
1 check passed
@hjiangsu hjiangsu deleted the fix/partial-comment-navigation branch May 15, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants