Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show post/comment language #1408

Merged
merged 4 commits into from
Jun 10, 2024
Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented May 31, 2024

Pull Request Description

  • This PR adds the ability to show the post language in the post metadata. If the language is Undetermined, nothing is displayed (matching the web UI).
  • There is also the ability to see the post/comment and languages in the bottom sheet (and we could possibly extend this area to include more metadata in the future, so people can see more info about posts/comments without cluttering up the default view).
qemu-system-x86_64_y1GDzgL7vJ.mp4

@hjiangsu
Copy link
Member

hjiangsu commented Jun 9, 2024

I think this looks good! Just a quick UI comment - for the language metadata in the bottom sheets, can we make it so that the background is transparent, rather than the dark grey?

I feel like the dark grey background brings a bit too much attention to the metadata. Let me know your thoughts!

@micahmo
Copy link
Member Author

micahmo commented Jun 9, 2024

I think this looks good! Just a quick UI comment - for the language metadata in the bottom sheets, can we make it so that the background is transparent, rather than the dark grey?

I feel like the dark grey background brings a bit too much attention to the metadata. Let me know your thoughts!

Of course! I simplified the bottom sheet to use the same LanguagePostCardMetaData as the post listing itself. Let me know if this looks good.

image

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 15b8c4e into thunder-app:develop Jun 10, 2024
1 check passed
@micahmo micahmo deleted the feature/show-language branch June 10, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants