Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add database import/export #1432

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Jun 6, 2024

Pull Request Description

This PR adds a way to export and import the Thunder database. This can be helpful when performing a new installation to bring back all of the previously saved customizations that are outside of the preferences. This should also allow us to put even more info in the db without worrying that the user won't have any way to preserve it.

I have also added some descriptions to "Save Settings" and "Export Database" so the user understands what data is included. I've added snackbars for import/export so it's clear when the operations have succeeded.

Finally, a confirmation message is shown when exporting the database to warn the user that it may contain sensitive data (i.e., their JWT) and not to share it with anyone.

qemu-system-x86_64_QQ9lDUxfsR.mp4

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment up for discussion!

@hjiangsu hjiangsu added this to the 0.5.0 milestone Jun 9, 2024
@hjiangsu hjiangsu merged commit f563dbb into thunder-app:develop Jun 10, 2024
1 check passed
@micahmo micahmo deleted the feature/db-import-export branch June 10, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants