Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix experimental post page comment pagination #1445

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Fix experimental post page comment pagination #1445

merged 1 commit into from
Jun 13, 2024

Conversation

hjiangsu
Copy link
Member

Pull Request Description

I forgot to add in pagination for comments for the new experimental post page. This PR fixes that!

Issue Being Fixed

Issue Number: #1413

Screenshots / Recordings

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@hjiangsu hjiangsu changed the title Fix issue where experimental post page was not paginating comments Fix experimental post page comment pagination Jun 12, 2024
micahmo
micahmo approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit ad83dbc into develop Jun 13, 2024
1 check passed
@hjiangsu hjiangsu deleted the fix/post-page-comment-pagination branch June 13, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micahmo micahmo micahmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hjiangsu @micahmo