Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user profile showing general feed #1456

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

hjiangsu
Copy link
Member

Pull Request Description

This PR fixes a regression where navigating to the user's profile page would show the general feed rather than the user's posts. This was caused by #1436, where a default fallback was added in to fetch the current account's default feed type. That default fallback has been removed, and the calling function must now explicitly pass in the postListingType in order to fetch the general feeds.

Issue Being Fixed

Issue Number: #1454

Screenshots / Recordings

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 6b73021 into develop Jun 17, 2024
1 check passed
@hjiangsu hjiangsu deleted the fix/user-profile-feed branch June 17, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants