Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow navigating to user instance from post sheet #1511

Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Aug 1, 2024

Pull Request Description

Currently when you long-press a post, you can perform actions on the instance of the post/community, but not the user. (You can perform actions related to the instance of the user from a comment.) This PR improves the instance sub-menu in the post bottom sheet to provide actions related to both the post/community and the user. If they are on the same instance, only one set of actions is shown.

I also made a small tweak to only show the post metadata chips (i.e., the post language) on the main page of the sheet.

qemu-system-x86_64_gaL4jfRpns.mp4

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit e045dfe into thunder-app:develop Aug 4, 2024
1 check passed
@micahmo micahmo deleted the feature/user-instance-from-post branch August 5, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants