Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove USE_EXACT_ALARM #1533

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Remove USE_EXACT_ALARM #1533

merged 1 commit into from
Aug 15, 2024

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Aug 14, 2024

Pull Request Description

This PR removes the USE_EXACT_ALARM permission to satisfy new Google Play requirements.

  • I did not remove the permission from the debug manifest, so we can continue to use more precise alarms for testing. If this still causes issues with Google Play, I can remove it.
  • I changed the minimum alarm time to 15 for the background local notification test, and I removed forceAlarmManager. Most likely I didn't really have to change the time since it won't be sooner than 15 minutes anyway, but I figured having that number in the code would at least make things more clear.
  • I updated the message that is displayed when the user initiates the background local notification test to indicate that it will likely take around 15 minutes until the notification appears. I also tested it, and this was the case.

Issue Being Fixed

Issue Number: #1532

Screenshots / Recordings

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for doing this 😄 - I'll let you know if the Google Play build processes properly

@hjiangsu hjiangsu merged commit f02fbfa into thunder-app:develop Aug 15, 2024
1 check passed
@micahmo micahmo deleted the fix/arlarm branch August 15, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants