-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Upgrade dependencies for Flutter 3.24 compatibility #1565
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Feel free to merge this now and I'll let you know if I run into any issues as I daily drive it.
Hey @hjiangsu I believe I've seen at least two issues related to color after the upgrade. Note that I don't have an old version to test against, so this is just from memory (although I'm sure we could dig up screenshots from other PRs). I believe the bottom nav bar should have a shaded color and not blend into the background of the posts.
I believe each of the reply cards is supposed to have a tinted background.
|
A couple more things to add onto this!
|
It looks like Feel free to try it out if you'd like and let me know if there are any other issues noted. I'm mainly waiting for To use the latest pre-release, set |
Pull Request Description
This PR updates Thunder to be compatible with Flutter 3.24. I've upgraded all the packages to their latest versions (using
flutter pub upgrade --major-versions
)Note: The package
flex_color_scheme
has not been updated yet as the next version is still a WIP. However, I opted to continue with the upgrade regardless to reduce potential tech debt from upgrading between multiple major Flutter versions (e.g., 3.22, 3.24, etc.)Due to this, there may be some visual bugs associated with the upgrade. I'll see if there are any simple workarounds for these issues in future PRs.
@micahmo I've tested the build on Android and it looks to be building properly, but let me know if you encounter any issues! I'll be closing this PR (#1372) as this one supersedes it
Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Checklist
semanticLabel
s where applicable for accessibility?