Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a couple more color/theme things #1635

Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Dec 12, 2024

This PR fixes two more color issues

  • The modlog status bar (same fix as Fix the status bar color on the post page #1630 and Fix status bar color #1615)
    • This appears to be the last case of SafeArea.top being determined by the hideTopBarOnScroll setting, so hopefully we're done with these fixes.
    • I also allowed the SafeArea to go under the bottom nav bar, which makes the app feel more edge-to-edge, and also matches the post/comment page.
  • The create post/comment page nav bar
    • Pretty similar fix here. I allowed the SafeArea to go under the nav bar and added a Container with the same background color as the MarkdownToolbar to fill the space. I verified that opening the keyboard only causes the toolbar to jump up and not the extra container.

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit a9cccda into thunder-app:develop Dec 17, 2024
1 check passed
@micahmo micahmo deleted the fix/a-couple-more-color-things branch December 17, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants