Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide profile/hamburger during feed refresh #1641

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Dec 16, 2024

Pull Request Description

I noticed that when you refresh the feed, everything disappears (including all app bar action widgets) except the hamburger menu button (or the profile picture, depending on the settings). I think it looks a little funny, especially when it's the profile. Sticks out like a sore thumb. So I thought I'd just make a super minor change so that whatever icon is in the top-left also disappears during a reload.

Please review without whitespace.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Before

profile-refresh-before.mp4

After

profile-refresh-after.mp4

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 849b3ba into thunder-app:develop Dec 17, 2024
1 check passed
@micahmo micahmo deleted the feature/refresh-feed branch December 17, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants