Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to gradle declarative plugin #1650

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

hjiangsu
Copy link
Member

Pull Request Description

This PR updates our Android project to use gradle's declarative plugin. To read more about the migration, see here: https://docs.flutter.dev/release/breaking-changes/flutter-gradle-plugin-apply.

@micahmo if you could attempt to build this and run it on your device, that would be great! More specifically, I would check to see if local notifications work after this as background_fetch and flutter_local_notifications require setup that changes these files.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I built and ran this branch on my physical device, and it seems to be working well! I tested local notifications via the debug page (both the immediate and delayed/background notifications) and they worked fine!

@hjiangsu hjiangsu merged commit a62f899 into develop Jan 2, 2025
1 check passed
@hjiangsu hjiangsu deleted the chore/gradle-declarative-plugin branch January 2, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants