Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show progress indicator during post refresh #1671

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Jan 22, 2025

Pull Request Description

This PR fixes a small quirk of the experimental/new post page that has been "bothering" me for a while. The quirk is that while the comments are loading, the spinner goes away before the comments are fully loaded and there is a brief pause. I've tried to capture it in the screen recording below, but the pause is much "worse" when you're on a slower network (which is what implied to me that there was still something loading, as opposed to just being a visual/layout glitch).

Turns out all I had to do was handle an additional state, and it looks much better now!

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Before

qemu-system-x86_64_xwVJB3SlJS.mp4

After

qemu-system-x86_64_m6noSFAa5F.mp4

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 985eaee into thunder-app:develop Jan 24, 2025
1 check passed
@micahmo micahmo deleted the fix/refresh-post branch January 24, 2025 16:36
@micahmo
Copy link
Member Author

micahmo commented Jan 24, 2025

Hey @hjiangsu I just noticed that this change causes the comments to "reload" when you do something like upvote or save. Would you be able to roll this back and I'll work on a better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants