Show progress indicator during post refresh #1671
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR fixes a small quirk of the experimental/new post page that has been "bothering" me for a while. The quirk is that while the comments are loading, the spinner goes away before the comments are fully loaded and there is a brief pause. I've tried to capture it in the screen recording below, but the pause is much "worse" when you're on a slower network (which is what implied to me that there was still something loading, as opposed to just being a visual/layout glitch).
Turns out all I had to do was handle an additional state, and it looks much better now!
Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Before
qemu-system-x86_64_xwVJB3SlJS.mp4
After
qemu-system-x86_64_m6noSFAa5F.mp4
Checklist
semanticLabel
s where applicable for accessibility?