Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show full URLs in tooltip #582

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Aug 8, 2023

Pull Request Description

This PR allows the full text of a URL to be shown upon activating the tooltip.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

qemu-system-x86_64_qwvDAcanvs.mp4

Checklist

N/A

@CTalvio
Copy link
Collaborator

CTalvio commented Aug 8, 2023

Could also appear on long tapping the thumbnail.

@micahmo
Copy link
Member Author

micahmo commented Aug 8, 2023

Could also appear on long tapping the thumbnail.

Relay has a cool feature where long-tapping the thumbnail shows the image, and then releasing closes it. Not sure if we'd ever want that.

@machinaeZER0
Copy link
Collaborator

Could also consider (either in addition to or instead of the tooltip popup) putting the URL at the top of the long press menu, prior to the Actions list?

Relay has a cool feature where long-tapping the thumbnail shows the image, and then releasing closes it. Not sure if we'd ever want that.

I legit thought that was a feature in Thunder, lol. I must have used it when testing some other Lemmy app!

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 1a05547 into thunder-app:develop Aug 15, 2023
@micahmo micahmo deleted the feature/url-tooltips branch August 15, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants