Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide gesture customize hint #599

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Hide gesture customize hint #599

merged 3 commits into from
Aug 15, 2023

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Aug 9, 2023

Pull Request Description

Hide the gesture customize hint when the gestures are disabled.

Issue Being Fixed

The customize hint would remain, even when the option was off and the selector was hidden.

Checklist

  • Did you update CHANGELOG.md? -- N/A -- minor UI tweak
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

hjiangsu
hjiangsu approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit c2d7d68 into thunder-app:develop Aug 15, 2023
@micahmo micahmo deleted the fix/hide-customization-hint branch August 15, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjiangsu hjiangsu hjiangsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@micahmo @hjiangsu