make comment indicators use theme via alpha blending #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Changes the post comment indicators from using a list of static colours to instead use alpha blends of those static colours with the current theme's primary colour. This ensures that the colours are more harmonious and fit better into the selected theme.
This change was suggested as part of the discussion on #603.
The affect is fairly subtle - there's a balance between keeping the colours obviously distinct and having them fit the palette of the theme.
Issue Being Fixed
The current comment indicator colours don't match the selected theme and so stick out a bit.
Issue Number: N/A
Screenshots / Recordings
Checklist
semanticLabels where applicable for accessibility?