#665: Indicators for locked posts + reply prevention

[ajsosa]

Pull Request Description

Added a lock icon prefixing post titles for locked posts in both comfortable and compact view. Also replaced reply button in post view with lock as well as the FAB reply button. Commenting operations are blocked and a toast will notifying explaining that the post is locked.

Issue Being Fixed

#665

Screenshots / Recordings

Checklist

• Did you update CHANGELOG.md?
• Did you use localized strings where applicable?
• Did you add semanticLabels where applicable for accessibility?

[ajsosa]

@micahmo It just occurred to me that these changes will probably have merge conflicts with #648. I'm cool with reviewing and merging your stuff first and then fixing my PR.

[micahmo]

LGTM, just left a couple minor comments. About the conflicts, yeah you're probably right. Mine's pretty big but you're welcome to review if you want!

[CTalvio]

Are we keeping the lock icons at the start of titles, and pin icons at the end? That seems inconsistent. Either change locked to be at the end, or pins and favorites to also be at the beginning.

[ajsosa]

@CTalvio Yeah I noticed that yesterday. I think I would prefer both to prefix the title so that their placement is always consistent.

[micahmo]

@ajsosa One thing I forgot to mention on the topic of the other indicators. Make sure the lock icon dims when the post is read. See here for example.

https://github.com/thunder-app/thunder/blob/develop/lib/community/widgets/post_card_view_comfortable.dart#L127

[ajsosa]

@micahmo Made the lock icon dim.

[micahmo]

Perfect! Did you still want to do #648 first, or would you rather this one goes first?

[ajsosa]

@micahmo I'll try to get to reviewing your changes later today. But if you would prefer to merge my stuff in first that's fine too. your call.

[micahmo]

I don't have a strong preference, so I guess we can just go in the order they were created if that's ok. (And I promise it's not just because it benefits me this time. 😆)

[ajsosa]

@micahmo Looks like there are no conflicts and my lock changes to FAB work seamlessly with your changes :D

[micahmo]

Sweet!!

[micahmo]

@ajsosa Did you intend to move saved to the beginning of the title? Looks like it's still at the end.

[ajsosa]

@micahmo I've never saved a post so had no idea that even existed. But yeah I can move it.

[CTalvio]

The padding on the pin icon is also on the wrong side now.