Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance bottom pickers #686

Merged
merged 8 commits into from
Sep 5, 2023
Merged

Enhance bottom pickers #686

merged 8 commits into from
Sep 5, 2023

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Aug 25, 2023

Pull Request Description

This PR refactors the picker item widgets for better maintenance and adds some small enhancements to the items.

  1. Add inkwell animation.
  2. Show currently selected item (I've been wanting this for a while!).
  3. Localize strings.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

qemu-system-x86_64_SqYADZZnOS.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@micahmo micahmo requested a review from ajsosa August 25, 2023 15:06
hjiangsu
hjiangsu approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Is this ready to be merged?

@micahmo
Copy link
Member Author

micahmo commented Sep 5, 2023

Yes!

@hjiangsu hjiangsu merged commit ead0199 into thunder-app:develop Sep 5, 2023
@micahmo micahmo deleted the feature/picker-enhancements branch September 5, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjiangsu hjiangsu hjiangsu approved these changes

@ajsosa ajsosa Awaiting requested review from ajsosa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@micahmo @hjiangsu