-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve user colors #710
Improve user colors #710
Conversation
I think it looks good! Maybe others have suggestions or feedback on the general colours? |
I wouldn't be opposed to having these match what's used for lemmy on the web side, and/or staying consistent across theme choice so users are on the same page regarding identification by color at a glance. I do also like the proposed implementation for this use case though, and I think it does probably make sense more than slightly different shades of the theme color. |
The only thing I might think to try, is that I've been thinking it might be fun to use a gradient of the multiple colors, when someone has more than one thing. |
That's an interesting idea! I agree that having only one color is a bit of a limitation, although (a) the priority of colors has been intentionally selected and (b) the icons and tooltip still provide all the information. |
I think it looks awesome! |
It seems like everyone is in agreement so I'll go ahead and merge this in!
This is an interesting idea, and we can revisit this at a later time! |
Pull Request Description
This PR adjusts the special user chip colors. Currently many of the colors looks very similar (e.g., OP, self, and mod are all shades of
bluethe current theme color), so this should provide some distinction while still following the current theme.Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Before
After
OP / Self / Mod in Different Themes
Bot
Admin
Checklist
semanticLabel
s where applicable for accessibility?