Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drawer folder list - Part 2 #8131

Merged
merged 10 commits into from
Sep 11, 2024

Conversation

wmontwe
Copy link
Member

@wmontwe wmontwe commented Sep 10, 2024

Second part of the drawer folder list implementation #8118. The direct dependencies, like AccountsViewModel and FoldersViewModel, have been moved to the feature module. The UI related functionality has been separated from the FolderRepository and moved into DisplayFolderRepository, to clarify responsibilities. Related data models have been moved out of legacy to where they are actually used.

This introduces a new :core:mail:folder:api module for folder specific declarations.

@wmontwe wmontwe requested a review from cketti as a code owner September 10, 2024 14:16
Copy link
Member

@cketti cketti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Side note: The classes in a feature module that are not part of the exposed "API" could use the internal visibility modifier.

@wmontwe
Copy link
Member Author

wmontwe commented Sep 11, 2024

LGTM

Side note: The classes in a feature module that are not part of the exposed "API" could use the internal visibility modifier.

Right, I'll do that in a follow up pull-request

@wmontwe wmontwe merged commit e06f57f into thunderbird:main Sep 11, 2024
2 checks passed
@wmontwe wmontwe deleted the add-drawer-folder-list-part2 branch September 11, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants