Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TalkBack Accessibility for Contribution Amounts #8756

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

terofeev
Copy link
Contributor

Fixes #8346

This update applies Modifier.selectable instead of Modifier.clickable.

As a result, TalkBack now pronounces these examples correctly:

  • Not selected Give once Radio button, double tap to toggle
  • Selected Monthly Radio button
  • Selected 25 dollars Radio button

To resolve this issue, the enabled = !isSelected argument was removed. This allows users to select a type of contribution even if it is already selected. When this happens, the selected amount is reset to the second-lowest option.

@wmontwe wmontwe self-assigned this Jan 17, 2025
Copy link
Member

@wmontwe wmontwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@wmontwe wmontwe merged commit 5175031 into thunderbird:main Jan 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contribution amounts function as a radio group but are not presented to assistive technology as such
2 participants