Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: 🤖 remove @angular-devkit/build-angular peerDep #2880

Merged
merged 1 commit into from
Nov 28, 2024
Merged

chore: 🤖 remove @angular-devkit/build-angular peerDep #2880

merged 1 commit into from
Nov 28, 2024

Conversation

danymarques
Copy link
Contributor

Summary

This update ensures compatibility for projects still using Angular 18 by removing the need to explicitly list the @angular-devkit/build-angular dependency. This is achieved by enabling the direct use of builders from @angular/build.

Test plan

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

ahnpnl
ahnpnl approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@ahnpnl ahnpnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in the past we used to use this dep but now the existing codes don't use it anymore. It's safe to remove. Thanks!

@ahnpnl ahnpnl merged commit 2f6bc3d into thymikee:main Nov 28, 2024
9 checks passed
@danymarques
Copy link
Contributor Author

I think in the past we used to use this dep but now the existing codes don't use it anymore. It's safe to remove. Thanks!

Yes, I checked beforehand if it was used or not 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahnpnl ahnpnl ahnpnl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danymarques @ahnpnl