Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tars plugin has redundant merge base operations #643

Closed
1 task done
Mini256 opened this issue Jul 12, 2021 · 2 comments
Closed
1 task done

Tars plugin has redundant merge base operations #643

Mini256 opened this issue Jul 12, 2021 · 2 comments
Labels
type/bug The issue is confirmed as a bug.

Comments

@Mini256
Copy link
Member

Mini256 commented Jul 12, 2021

Bug Report

  • I have searched the issues of this repository and believe that this is not a duplicate.

What is expected?

Tars do not perform unnecessary merge-base operations.

What is actually happening?

case 1: pingcap/tidb#25792

In this case, tars was triggered almost twice at the same time. It may be that the push event and the timed task triggered tars almost at the same time, resulting in repeated merge base operations.

case 2:pingcap/tidb-operator#4171

In this case, PR is modified based on the latest base, and three commits are submitted in this PR, but the tars plugin that is triggered regularly is considered the base of PR is out-of-date.

case 3: tikv/tikv#10746

In this case, the robot will reply to two comments after /merge. Such three comments will trigger tars at the same time, and there will be a race condition problem.

@Mini256 Mini256 added the type/bug The issue is confirmed as a bug. label Jul 12, 2021
@Mini256 Mini256 changed the title Tars repeated Merge Master operation Tars plugin has redundant merge base operations Sep 2, 2021
@ti-chi-bot
Copy link
Member

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-community-infra or Mini256.
/lifecycle stale

@ti-chi-bot
Copy link
Member

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Send feedback to sig-community-infra or Mini256.
/lifecycle rotten

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug The issue is confirmed as a bug.
Projects
None yet
Development

No branches or pull requests

2 participants