Changed SCRIPT_ADDRESS version byte from 5 to 22 to comply with other address tools #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gin with 9 or A to match existing tools which support addresses beginning with D.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEFCOIN P2PKH addresses begin with a D, such as DPuE992x5UmbUj6Hb3783JSQ5a3GAyMHpZ, but P2SH addresses currently begin with a 3, such as 3ChiCWdXotownkore5tyFYuzRydYzrBmkB.
These can be confused with Bitcoin's P2SH addresses which also begin with a 3.
This pull request alters DEFCOIN's P2SH address prefix so that P2SH addresses begin with either 9 or A. This is compliant with existing tools which observe the "P2PKH+8" convention between P2PKH and P2SH prefixes, such as pycoin, Beerwallet, and any other library that can create addresses.
While at first glance this change may seem 'cosmetic only' since transactions do not use the addresses that are displayed within the client (they use the hash160 of the public key which is encoded within addresses), it's actually important because the "Send to" dialog will reject non-conforming addresses. This change ensures the "Send to" dialog doesn't accept Bitcoin P2SH addresses, and only accepts P2SH addresses that were built for DEFCOIN.