Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capsule install fix for the inf_generators. #352

Merged

Conversation

kenlautner
Copy link
Contributor

@kenlautner kenlautner commented Jun 9, 2023

Pr #315 Introduced a bug with capsule update from the OS where the capsule update fails and shows up as error: missing file %hs. This fixes that bug by correctly putting the FirmwareIntegrityFilename into the new directory with FirmwareFilename.

Fixes Issue #351

Tested on Intel physical platforms.

@Javagedes Javagedes added this to the 0.15.3 milestone Jun 12, 2023
@Javagedes Javagedes added the bug Something isn't working label Jun 12, 2023
@Javagedes
Copy link
Contributor

@kenlautner Thank you for catching this. The tests for inf_generator and inf_generator2 will need to be updated to reflect the %13% addition. Let me know if you have any issues with that. Once done I'll merge and do a release.

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (96ed4cf) 78.65% compared to head (7068d77) 78.65%.

❗ Current head 7068d77 differs from pull request most recent head bd05700. Consider uploading reports for the commit bd05700 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #352   +/-   ##
=======================================
  Coverage   78.65%   78.65%           
=======================================
  Files          47       47           
  Lines        6742     6742           
=======================================
  Hits         5303     5303           
  Misses       1439     1439           
Impacted Files Coverage Δ
edk2toollib/windows/capsule/inf_generator.py 95.31% <100.00%> (ø)
edk2toollib/windows/capsule/inf_generator2.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Javagedes Javagedes force-pushed the personal/klautner/fix_capsule_inf branch from 7068d77 to bd05700 Compare June 12, 2023 16:29
@Javagedes Javagedes enabled auto-merge (squash) June 12, 2023 16:30
@Javagedes Javagedes merged commit 022ae03 into tianocore:master Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Capsule Update broken from OS
2 participants