Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dec_parser: support parsing pcd strings with pipes #365

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

Javagedes
Copy link
Contributor

previously, the dec parser would fail to parse a PcdDeclarationEntry that contained a pipe symbol in the default value. This commit updates the parser to detect pipes wrapped in quotes and not split on it.

closes #234

previously, the dec parser would fail to parse a PcdDeclarationEntry
that contained a pipe symbol in the default value. This commit updates
the parser to detect pipes wrapped in quotes and not split on it.
@Javagedes Javagedes added the bug Something isn't working label Jul 13, 2023
@Javagedes Javagedes added this to the v0.15.4 milestone Jul 13, 2023
@Javagedes Javagedes requested a review from makubacki July 13, 2023 21:43
@Javagedes Javagedes self-assigned this Jul 13, 2023
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (fd3aac5) 78.68% compared to head (e527585) 78.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #365   +/-   ##
=======================================
  Coverage   78.68%   78.68%           
=======================================
  Files          47       47           
  Lines        6727     6729    +2     
=======================================
+ Hits         5293     5295    +2     
  Misses       1434     1434           
Impacted Files Coverage Δ
edk2toollib/uefi/edk2/parsers/dec_parser.py 92.73% <100.00%> (+0.08%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@makubacki
Copy link
Member

Did you check if this was an issue in some other parsing logic like PCDs being assigned in DSC files?

@Javagedes
Copy link
Contributor Author

Did you check if this was an issue in some other parsing logic like PCDs being assigned in DSC files?

No, But I just did:

  1. The dsc_parser and inf_parser only record the token_space name & name, so a string value with a | would not break them.
  2. The other parsers do not do anything with PCDs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: \edk2toollib\uefi\edk2\parsers\dec_parser.py fails parsing PCDs when a string contains '|'
2 participants