edk2toollib/uefi/edk2/parsers: enhancements #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Javagedes
force-pushed
the
improve-pcd-parsing
branch
2 times, most recently
from
e0eb86a to
b47095b
Compare
This change temporarily registers pcd values when doing the initial parse of the dsc file looking for defines. This is necessary for processing conditionals that use PCD values
Fixes the bug where the `ComputeResult` attempts to evaluate the result using the original string value, rather than the converted int value when handling greater than or less than conditions. It should have been using the ivalue, which is the conversion of the parsing string into an actual integer (i.e. "1" to 1 or "0x0" to 0).
Javagedes
force-pushed
the
improve-pcd-parsing
branch
from
b47095b to
ceceefa
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #419 +/- ##
==========================================
+ Coverage 80.93% 81.03% +0.10%
==========================================
Files 57 57
Lines 7286 7289 +3
==========================================
+ Hits 5897 5907 +10
+ Misses 1389 1382 -7
☔ View full report in Codecov by Sentry. |
apop5
approved these changes
Sep 29, 2023
makubacki
reviewed
Sep 29, 2023
makubacki
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the following parsers in the following ways:
base_parser.py: Properly uses ivalue (int value) to check if the string representation of a value was correctly converted to an integer ('1' to 1, '0x0' to 0, etc) when evaluating conditionalsdsc_parser.py: register pcds when performing the initial parse responsible for finding define statements. This is necessary to evaluate conditionals that use pcds.