base_parser.py: conditional evaluation bugfix #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recent changes to conditional evaluations to support evaluating non decimal integers such as hex strings broke the ability to evaulate define macro replacements that are integers. This is a bugfix to keep that support along with additional tests to ensure it does not break in the future.
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #425 +/- ##
=======================================
Coverage 81.03% 81.03%
=======================================
Files 57 57
Lines 7289 7289
=======================================
Hits 5907 5907
Misses 1382 1382
☔ View full report in Codecov by Sentry. |
kuqin12
approved these changes
Oct 6, 2023
makubacki
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recent changes to conditional evaluations to support evaluating non decimal integers such as hex strings broke the ability to evaulate define macro replacements that are integers. This is a bugfix to keep that support along with additional tests to ensure it does not break in the future.