path_utilities: Remove Nested package exceptions #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #430 +/- ##
==========================================
- Coverage 81.07% 81.03% -0.04%
==========================================
Files 57 57
Lines 7285 7270 -15
==========================================
- Hits 5906 5891 -15
Misses 1379 1379
☔ View full report in Codecov by Sentry. |
makubacki
reviewed
Oct 11, 2023
makubacki
approved these changes
Oct 11, 2023
Removes Nested package exceptions from path_utilities.py in favor of a warning. This is being done as the exception has served its purpose and those willing to update their nested packages have had a year to do so. Any nested packages will now only be a warning logged at logging.DEBUG and issues with converting from an absolute path to an edk2 package path relative path will be accepted. A new CI Check has been added so that packages managed by that specific repository will still be checked by nested packages, but nested packages outside of the control of that specific repository will not be checked and thus not result in an exception being raised.
Javagedes
force-pushed
the
edk2-path-update
branch
from
b3b2559 to
f604863
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes Nested package exceptions from path_utilities.py in favor of a warning. This is being done as the exception has served its purpose and those willing to update their nested packages have had a year to do so. Any nested packages will now only be a warning logged at logging.DEBUG and issues with converting from an absolute path to an edk2 package path relative path will be accepted.
A new CI Check has been added so that packages managed by that specific repository will still be checked by nested packages, but nested packages outside of the control of that specific repository will not be checked and thus not result in an exception being raised.
closes #200