Limiting capsule install to supported versions #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makubacki
approved these changes
Oct 11, 2023
bkarstens
changed the title
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #431 +/- ##
=======================================
Coverage 81.07% 81.07%
=======================================
Files 57 57
Lines 7285 7285
=======================================
Hits 5906 5906
Misses 1379 1379
☔ View full report in Codecov by Sentry. |
Javagedes
approved these changes
Oct 12, 2023
Javagedes
pushed a commit
that referenced
this pull request
Apr 2, 2024
Limit capsule install inf changes to OS versions 17134 or higher for a newer HDC requirement. Original PR - #431 "According to Zac Lockard for the InfVerif team, the new WHCP requirements went into force with the newest 26080 build which is why we're seeing this now. For reference, they link https://learn.microsoft.com/en-us/windows-hardware/drivers/devtest/inf-validation-errors-and-warnings#1199 and quote the page that says "You must fix all errors in order to pass driver tests in Hardware Dev Center." It is the Device.DevFund.INF.Syntax requirement This change was also pushed to all older versions of the OS due to this being a problem often in the ecosystem".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inf generators generate capsules with:
The syntax 'DIRID 13' was introduced in OS version 10.0.16299, but DDInstall sections utilizing the syntax will install on earlier OS versions. Those DDInstall sections should be restricted to only install on 10.0.16299 or higher using a TargetOSVersion decoration.
See Combining platform extensions with operating system versions
Tested before and after with
infverif.exe