Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected Logger case to logger in error condition #438

Merged

Conversation

apop5
Copy link
Contributor

@apop5 apop5 commented Oct 26, 2023

In a less used conditional case, self.Logger was referenced, whereas in the rest of the file self.logger is used. Resulted in an exception.

File "Lib\site-packages\edk2toollib\uefi\edk2\path_utilities.py", line 111, in init
self.Logger.log(logging.WARNING, warning)
^^^^^^^^^^^
AttributeError: 'Edk2Path' object has no attribute 'Logger'. Did you mean: 'logger'?

@Javagedes Javagedes added this to the 0.19.3 milestone Oct 26, 2023
@Javagedes Javagedes added the bug Something isn't working label Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2e82a08) 81.01% compared to head (61d5022) 81.01%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #438   +/-   ##
=======================================
  Coverage   81.01%   81.01%           
=======================================
  Files          57       57           
  Lines        7284     7284           
=======================================
  Hits         5901     5901           
  Misses       1383     1383           
Files Coverage Δ
edk2toollib/uefi/edk2/path_utilities.py 96.55% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Javagedes Javagedes merged commit 139e41b into tianocore:master Oct 26, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants