utility_functions: Add LongPath support to RemoveTree #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows systems with long paths disabled, the RemoveTree function fails to remove files that go over the character limit as they cannot be found. This change, on windows, prefixes the path with the '\\?\' which allows for the detection of long paths, and allows for the removal of the file.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #444 +/- ##
==========================================
- Coverage 81.01% 80.99% -0.03%
==========================================
Files 57 57
Lines 7284 7286 +2
==========================================
Hits 5901 5901
- Misses 1383 1385 +2
☔ View full report in Codecov by Sentry. |
makubacki
reviewed
Nov 1, 2023
makubacki
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows systems with long paths disabled, the RemoveTree function fails to remove files that go over the character limit as they cannot be found. This change, on windows, prefixes the path with the '\\?\' which allows for the detection of long paths, and allows for the removal of the file.
Closes #445