Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PCD parsing for PCDs that have a single quote in them #600

Merged
merged 4 commits into from
Jul 25, 2024

Conversation

NishanthSanjeevi
Copy link
Contributor

The PCD parsing regex pattern failed for PCDs that had a single quote

For example,
gEfiMdePkgTokenSpaceGuid.PcdSingleQuote|"eng'fraengfra"|VOID*|0x0000002f
CRITICAL - EXCEPTION: Too few parts: ['PcdSingleQuote|"eng'fraengfra"', 'VOID*', '0x0000002f']

The new pattern should allow the usage of single quotes

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.31%. Comparing base (ce85203) to head (0473e78).
Report is 85 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #600      +/-   ##
==========================================
- Coverage   81.43%   81.31%   -0.13%     
==========================================
  Files          56       45      -11     
  Lines        7514     7486      -28     
==========================================
- Hits         6119     6087      -32     
- Misses       1395     1399       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Javagedes Javagedes added this to the v0.21.9 milestone Jul 22, 2024
@Javagedes Javagedes added the enhancement New feature or request label Jul 22, 2024
Copy link
Contributor

@Javagedes Javagedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test or two for this PR that test the new changes and supported logic. The test(s) would make sense here:

class TestPcdDeclarationEntry(unittest.TestCase):

@Javagedes Javagedes merged commit 60c64b0 into tianocore:master Jul 25, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants