buildreport_parser.py: Properly handle NULL libraries #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apop5
force-pushed
the
personal/apop5/buildreportparsernulls
branch
from
a5d56a2 to
70b36c6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #671 +/- ##
==========================================
- Coverage 81.43% 81.43% -0.01%
==========================================
Files 56 45 -11
Lines 7514 7492 -22
==========================================
- Hits 6119 6101 -18
+ Misses 1395 1391 -4 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Javagedes
force-pushed
the
personal/apop5/buildreportparsernulls
branch
from
70b36c6 to
5bf5a34
Compare
apop5
force-pushed
the
personal/apop5/buildreportparsernulls
branch
from
5bf5a34 to
74cbaa5
Compare
Javagedes
approved these changes
Nov 22, 2024
…st for a module, the library class name will be appended with an integer. For modules with 2 null libraries, they will be named NULL0 and NULL1.
Javagedes
force-pushed
the
personal/apop5/buildreportparsernulls
branch
from
74cbaa5 to
56d1988
Compare
Javagedes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, buildreport_parser maintains a dictionary of library classes.
This fails for NULL libraries. If more than one NULL library exists, only the last instance encountered will be in the dictionary.
To match edk2 build tool behavior, NULL libraries will have an instance number appened to the name.
i.e. NULL0, NULL1, etc