Convert TrueTime to use Date.now #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be a simpler approach that has less risk of clock drift that can happen with `performance.now()` used over idle time-spans. Using our `trueTime.now()` when setting performance marks should ensure all timestamps are of the same type/time-scale.
Coverage Report for Auth (packages/auth)
File CoverageNo changed files found. |
Coverage Report for Common (packages/common)
File CoverageNo changed files found. |
Coverage Report for Event Producer (packages/event-producer)
File CoverageNo changed files found. |
Coverage Report for Player Web Components (packages/player-web-components)
File CoverageNo changed files found. |
Coverage Report for Template (packages/template)
File CoverageNo changed files found. |
Coverage Report for True Time (packages/true-time)
File Coverage
|
||||||||||||||||||||||||||||||||||||||
…eady synchronized within an hour
enjikaka
reviewed
Feb 29, 2024
| async synchronize() { | ||
| if (this.#synced) { | ||
| async synchronize(): Promise<void> { | ||
| const anHour = 3_600_000; |
There was a problem hiding this comment.
I put 1_000_000 in PR since ChatGPT said this about NTP;
As a general guideline, a common default configuration for many systems is to synchronize every 64 to 1,024 seconds (approximately 1 to 17 minutes).
1 million ms is 16.67 minutes so figured that was nice. :P
There was a problem hiding this comment.
Hehe, so that was where you got the number from :-P I figured an hour should be frequent enough..
enjikaka
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be a simpler approach that has less risk of clock drift that can happen with
performance.now()used over idle time-spans.Using our
trueTime.now()when setting performance marks should ensure all timestamps are of the same type/time-scale.