-
-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change streamGetnow to factor in the processAhead and also destroy the sessionstate #1025
change streamGetnow to factor in the processAhead and also destroy the sessionstate #1025
Conversation
What is the expected behavior here? To get the cycle that would right now be hitting the speakers or roughly get the cycle that we would be processing at this moment? Reading the old code it seems like the latter is what was used, which would correspond to the change you are proposing. But I want us to reflect on what is most useful. Do we have some clear use cases for this function? If it is most used for the The old code: Tidal/src/Sound/Tidal/Stream.hs Lines 714 to 717 in a058922
|
The intended use is when someone wants to use the time of the stream to query a pattern for something (for example to highlight the pattern in the editor). When using this i encountered that with fast speeds there was a misalignment with the event that was playing and the one that was being highlighted. Adding the processAhead fixed the issue for me. so maybe we should rename this function to something else and keep the old one as streamGetnow? |
Great idea! What about |
rename to streamGetAhead and bring streamGetnow back in original version
i named it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, that's better and probably what I actually meant 😸 Great job!
Is this ready to merge? |
i think so! |
Thanks a lot! |
No description provided.