Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add metatune param #1042

Closed
wants to merge 1 commit into from
Closed

add metatune param #1042

wants to merge 1 commit into from

Conversation

ahihi
Copy link
Contributor

@ahihi ahihi commented Oct 11, 2023

adds support for the metatune functionality recently merged into SuperDirt.

to summarize:

  • WAV files can contain pitch metadata in a smpl chunk, commonly used by samplers for automatic pitch mapping
  • SuperDirt now reads and stores this metadata for each loaded sample
  • when the dirt_sample synth is passed metatune = 1, it tunes sample playback relative to the sample's pitch metadata

so given e.g. an instrument sample foo:2 recorded at F#4 and tagged as such in its metadata, it is now possible to do d1 $ note "c3" # s "foo:2" # metatune 1 and it will actually play at C3!

metatune defaults to 0, in which case C4 is used as the reference pitch, just like before. C4 is also the fallback when metatune = 1 but the specified sample lacks pitch metadata.

@yaxu
Copy link
Member

yaxu commented Oct 11, 2023

Thanks! I'm in the process of moving things around on the cycseq branch. I'll leave this PR open for now, and merge after #1031.

@matthewkaney
Copy link
Contributor

@ahihi Thanks! Would you mind submitting a PR with this change against the 1.9-dev branch? We're using the main branch for developing Tidal 2.0, but if you submit a patch on that branch it can get published sooner!

@ahihi
Copy link
Contributor Author

ahihi commented Oct 26, 2023

sure thing! closing this one.

@ahihi ahihi closed this Oct 26, 2023
@ahihi ahihi deleted the metatune branch October 26, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants