if first argument of euclid is negative, apply euclidInv #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is also patternable. + tests fixes tidalcycles#915
ndr-brt
reviewed
May 28, 2022
| @@ -756,7 +758,7 @@ euclid = tParam2 _euclid | |||
|
|
|||
| _euclid :: Int -> Int -> Pattern a -> Pattern a | |||
| _euclid n k a | n >= 0 = fastcat $ fmap (bool silence a) $ bjorklund (n,k) | |||
| | otherwise = _euclidInv (-n) k a | |||
| | otherwise = fastcat $ fmap (bool a silence) $ bjorklund (-n,k) | |||
There was a problem hiding this comment.
Is this correct? bjorklund should be called with (n,k)
There was a problem hiding this comment.
I think it is correct, this is the case of n < 0, so -n > 0 (otherwise bjorklund wouldn't produce anything). Note the reversed order of a and silence
There was a problem hiding this comment.
Yes, right, I did a wrong assumption! So ok for me 👍
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is also patternable.
fixes Mini-notation for euclidInv #915