Merge pull request #3 from zjj2wry/panic

fix when Id unknown causes null pointer exception
tidbcloud · Nov 20, 2020 · b91d6bd · b91d6bd
2 parents a795d3f + 8c2612e
commit b91d6bd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/Makefile b/Makefile
@@ -2,7 +2,7 @@
 export GOBIN := $(PWD)/bin
 export PATH := $(GOBIN):$(PATH)
 export INSTALL_FLAG=
-export TAG=0.4.1
+export TAG=0.4.2
 
 DOCKER_IMAGE = aws-limits-exporter
 DOCKER_REPO = gcr.io/pingcap-public

diff --git a/core/support.go b/core/support.go
@@ -217,6 +217,7 @@ func (e *SupportExporter) Describe(ch chan<- *prometheus.Desc) {
 		result, err := e.supportClient.DescribeServiceLimitsCheckResult(checkID)
 		if err != nil {
 			glog.Errorf("Cannot retrieve Trusted Advisor check results data: %v", err)
+			continue
 		}
 
 		for _, resource := range result.FlaggedResources {
@@ -252,6 +253,7 @@ func (e *SupportExporter) Collect(ch chan<- prometheus.Metric) {
 		result, err := e.supportClient.DescribeServiceLimitsCheckResult(checkID)
 		if err != nil {
 			glog.Errorf("Cannot retrieve Trusted Advisor check results data: %v", err)
+			continue
 		}
 
 		for _, resource := range result.FlaggedResources {