[WEB-3352] - TIDE Drawer Navigation Bugs #1500
Draft
+45
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henry-tp
changed the title
henry-tp
commented
Jan 16, 2025
| const params = new URLSearchParams(search); | ||
| params.delete('drawerPatientId'); | ||
| history.replace({ pathname, search: params.toString() }); | ||
| } |
There was a problem hiding this comment.
I really am not a fan of doing this kind of thing in side effects like this. I worked on a few of different solutions and this ended up being the best of the evils.
The main challenge is the question of how to make the drawer initialize in an open or closed state but without requiring the originating page to have contextual knowledge about the TIDE dashboard.
henry-tp
commented
Jan 21, 2025
| }) => { | ||
| const history = useHistory(); | ||
| const { search } = useLocation(); | ||
| const [initialSearchParams] = useState(new URLSearchParams(search)); |
There was a problem hiding this comment.
By storing in state here, I am just caching the value url searchParams at the first render, so that if the route changes, the back button has a reference to what the search params were on component mount
Screen.Recording.2025-01-21.at.11.08.10.mov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WEB-3352