Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-3274] Add data source management to device settings page #1501

Merged
merged 26 commits into from
Jan 27, 2025

Conversation

clintonium-119
Copy link
Member

@clintonium-119 clintonium-119 commented Jan 16, 2025

WEB-3274

Includes some work to consolidate container styles and making things like patient data nav and header more consistent in various responsive breakpoints

Related PRs

tidepool-org/tideline#448
tidepool-org/viz#434

Base automatically changed from WEB-3272-patient-data-linking-after-creation to develop January 23, 2025 21:13
Copy link
Member

@krystophv krystophv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small comments that don't hold up approval.

LGTM 🚢

test/unit/components/chart/basics.test.js Outdated Show resolved Hide resolved
app/components/elements/Card/Card.js Outdated Show resolved Hide resolved
app/themes/base/containers.js Outdated Show resolved Hide resolved
@clintonium-119 clintonium-119 merged commit 3c3537d into develop Jan 27, 2025
0 of 2 checks passed
@clintonium-119 clintonium-119 deleted the WEB-3274-device-settings-data-sources branch January 27, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants