[WEB-3377] - "Last Reviewed" and "PatientDrawer" flags occassionally missing on TIDE Dashboard #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henry-tp
changed the title
clintonium-119
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WEB-3377
To reliably repro this error on master, a specific QA user on QA2 can be used. You can DM me on slack for their details.
The issue was that because our fetch for flags is async, they are not always set to
trueon the first render. They are missing from the memo deps array, so they don't trigger a re-render. Adding them to the deps array ensures that a re-render is triggered when they are flipped totrue.