[BACK-2760] Punycode email addresses before sending.

clients/sesNotifier.go

@@ -1,7 +1,11 @@
 package clients
 
 import (
+	"fmt"
 	"log"
+	"net/http"
+
+	"golang.org/x/net/idna"
 
 	"github.com/aws/aws-sdk-go/aws"
 	"github.com/aws/aws-sdk-go/aws/awserr"
@@ -78,7 +82,11 @@ func NewSesNotifier(cfg *SesNotifierConfig) (*SesNotifier, error) {
 func (c *SesNotifier) Send(to []string, subject string, msg string) (int, string) {
 	var toAwsAddress = make([]*string, len(to))
 	for i, x := range to {
-		toAwsAddress[i] = aws.String(x)
+		encodedAddress, err := idna.ToASCII(x)
+		if err != nil {
+			return http.StatusBadRequest, fmt.Sprintf(`unable to Punycode email "%s": %v`, x, err)
+		}
+		toAwsAddress[i] = aws.String(encodedAddress)
 	}
 
 	input := &ses.SendEmailInput{
@@ -127,7 +135,7 @@ func (c *SesNotifier) Send(to []string, subject string, msg string) (int, string
 			log.Println(err.Error())
 		}
 
-		return 400, result.String()
+		return http.StatusBadRequest, fmt.Sprintf("%s: %s", result.String(), err.Error())
 	}
-	return 200, result.String()
+	return http.StatusOK, result.String()
 }

go.mod

@@ -13,6 +13,7 @@ require (
 	go.mongodb.org/mongo-driver v1.11.1
 	go.uber.org/fx v1.13.1
 	go.uber.org/zap v1.16.0
+	golang.org/x/net v0.0.0-20220513224357-95641704303c
 )
 
 require (
@@ -48,7 +49,6 @@ require (
 	go.uber.org/dig v1.10.0 // indirect
 	go.uber.org/multierr v1.5.0 // indirect
 	golang.org/x/crypto v0.0.0-20220622213112-05595931fe9d // indirect
-	golang.org/x/net v0.0.0-20220513224357-95641704303c // indirect
 	golang.org/x/sync v0.0.0-20210220032951-036812b2e83c // indirect
 	golang.org/x/text v0.3.7 // indirect
 	gopkg.in/jcmturner/aescts.v1 v1.0.1 // indirect