-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BACK-3295/BACK-3332] Implement private plugin functionality in platform, update dependencies #803
base: master
Are you sure you want to change the base?
Conversation
- Remove go generate --build_flags due to conflict with Go workspaces - Standardize mockgen usage in source files - Update to latest go.uber.org/mock/gomock - Remove unnecessary mocks - Remove unnecessary esc module
- Remove vendor directory and various unused dependencies - Remove Makefile deploy target - Remove golint dependency - Remove Code Climate dependency
… errors - Incorporate retry into OAuth client SendOAuthRequest for access token errors - Merge HTTPClientSource into TokenSource interface as unnecessary - Add generalized PrometheusCodePathResponseInspector - Update Dexcom Client with above changes
- Add minimal redwood plugin module and raw data and work packages - Integrate above into auth and data service - Remove unnecessary data.Context
- Add Go workspace to build with private plugins - Update Makefile with targets to switch between public and private configuration - Update Makefile to utilize new Go workspace - Update Makefile with minor target additions and changes - Update Makefile with changes to Docker build process - Update Makefile to allow generation of phony targets - Update Dockerfiles to fix image cache miss issues - Update .travis.yml to latest dependencies and use new Go workspace - Update to latest Go version - Update tools production image to use Mongo version matching production - https://tidepool.atlassian.net/browse/BACK-3295
- Update dependencies - https://tidepool.atlassian.net/browse/BACK-3332
Couldn't leave inline comments so adding few things that stood out:
Those issues don't need to be fixed immediately. The private build setup looks good! Thank you! |
- Add path pattern matching to PrometheusCodePathResponseInspector - Move common Dockerfile steps into separate common Dockerfile - Update Makefile to build common Dockerfile
Addressed the PR comments:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the latest commits after Todd's ok and LGTM
[BACK-3295/BACK-3332] Implement private plugin functionality in platform, update dependencies
➡️➡️➡️ NOTE: I suggest you review each separate commit independently. Each one is fairly isolated to a single intended change.