[MOD-2354] : Replace XZing library with AVFoundation framework #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansemannn
requested changes
Jul 31, 2018
ios/Classes/TiBarcodeModule.h
Outdated
| TiBarcodeViewController *barcodeViewController; | ||
| MTBCamera selectedCamera; | ||
| MTBTorchMode selectedLEDMode; | ||
| NSString *displayedMessage; |
There was a problem hiding this comment.
Please prefix all private properties with _.
| @property(nonatomic,readonly) NSNumber *FORMAT_EAN_13; | ||
| @property(nonatomic,readonly) NSNumber *FORMAT_CODE_128; | ||
| @property(nonatomic,readonly) NSNumber *FORMAT_CODE_39; | ||
| @property(nonatomic,readonly) NSNumber *FORMAT_ITF; |
There was a problem hiding this comment.
So we support all of these constants I assume?
ios/Classes/TiBarcodeModule.h
Outdated
| @property(nonatomic,readonly) NSNumber *FORMAT_CODE_128; | ||
| @property(nonatomic,readonly) NSNumber *FORMAT_CODE_39; | ||
| @property(nonatomic,readonly) NSNumber *FORMAT_ITF; | ||
| - (id)canShow:(id)unused; |
ios/Classes/TiBarcodeModule.h
Outdated
|
|
||
| - (void)setUseLED:(id)value; | ||
|
|
||
| - (id)useLED; |
ios/Classes/TiBarcodeModule.h
Outdated
|
|
||
| - (void)cancel:(id)unused; | ||
|
|
||
| - (void)setUseLED:(id)value; |
ios/Classes/TiBarcodeModule.m
Outdated
|
|
||
| - (id)canShow:(id)unused | ||
| { | ||
| return NUMBOOL([MTBBarcodeScanner cameraIsPresent] && ![MTBBarcodeScanner scanningIsProhibited]); |
There was a problem hiding this comment.
I start moving to @(value) instead of NUM***.
| withObject:@{ | ||
| @"message" : [error localizedDescription] ?: @"Unknown error occurred." | ||
| }]; | ||
|
|
There was a problem hiding this comment.
This looks weird. Did you format this?
ios/Classes/TiBarcodeModule.m
Outdated
|
|
||
| selectedLEDMode = [TiUtils boolValue:value def:YES] ? MTBTorchModeOn : MTBTorchModeOff; | ||
|
|
||
| if (barcodeViewController) { |
There was a problem hiding this comment.
Please always compare against nil, since barcodeViewController is not a boolean.
ios/Classes/TiBarcodeModule.m
Outdated
| [self replaceValue:value forKey:@"useFrontCamera" notification:NO]; | ||
|
|
||
| selectedCamera = [TiUtils boolValue:value def:YES] ? MTBCameraFront : MTBCameraBack; | ||
| NSError *cameraError; |
ios/Classes/TiBarcodeModule.m
Outdated
| { | ||
| ENSURE_SINGLE_ARG(args, NSDictionary); | ||
|
|
||
| id blob = [args valueForKey:@"image"]; |
There was a problem hiding this comment.
Try to prevent id whereever possible. Use TiBlob for this case and change all other id's if possible as well.
hansemannn
changed the title
|
@hansemannn Addressed the comments. Please review. Thanks! |
hansemannn
approved these changes
Aug 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/MOD-2354
Download: v2.0.0 Beta