Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add position correction status field #6

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

eduardacoppo
Copy link
Contributor

@eduardacoppo eduardacoppo commented Jan 23, 2025

Depends on:

What is this PR for

[sc-67376]
This PR adds a PositionCorrectionStatus enum

How I did it

POSITION_RAW -> initial value for the Position struct
POSITION_CENTERED_USING_HEADING -> position was corrected using the vessels heading (yaw angle)
POSITION_CENTERED_USING_COURSE -> position was corrected using the vessels course_over_ground angle.

Results, How I tested

Checklist

  • Assign yourself in the PR
  • Write unit tests (when relevant)
  • Run rubocop and rake tests locally
  • If this PR initialize a CMAKE package please enable styling and linting
  • Analyse if this PR modifies the UI, if so:
    • Tested Tupan's simulation (Charts) 🗺️
    • Tested Tupan's simulation (Hud) 🕹️
    • Tested ROV's simulation 🕹️

@eduardacoppo eduardacoppo force-pushed the add_position_correction_status branch from 1ff99dd to 91c1769 Compare January 23, 2025 13:27
@eduardacoppo eduardacoppo merged commit 9bea834 into master Jan 24, 2025
1 check passed
@eduardacoppo eduardacoppo deleted the add_position_correction_status branch January 24, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants