fix: test against PPS_CANWAIT in pps caps instead of params #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spec says params but it is readonly (which is ... weird), but it seems that it should really be checked in the caps. It does make more sense, and it is what gpsd does. The params PPS_CANWAIT is cleared on boot on BBBs, but appears magically once chrony ran at least once. My guess is that it appears after the type of assertions has been configured.
jhonasiv
approved these changes
Feb 10, 2025
kapeps
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec says params but it is readonly (which is ... weird), but it seems that it should really be checked in the caps. It does make more sense, and it is what gpsd does.
The params PPS_CANWAIT is cleared on boot on BBBs, but appears magically once chrony ran at least once. My guess is that it appears after the type of assertions has been configured.