transition from expect_message()

tidymodels · Oct 21, 2024 · 70f6256 · 70f6256
1 parent babe435
commit 70f6256
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 5 deletions.
diff --git a/tests/testthat/_snaps/ergm.md b/tests/testthat/_snaps/ergm.md
@@ -14,3 +14,10 @@
       Warning in `tidy.ergm()`:
       Exponentiating but model didn't use log or logit link.
 
+# glance.ergm
+
+    Code
+      gl3 <- glance(gest, deviance = TRUE, mcmc = TRUE)
+    Message
+      Though `glance` was supplied `mcmc = TRUE`, the model was not fittedusing MCMC, so the corresponding columns will be omitted.
+
diff --git a/tests/testthat/_snaps/stats-htest.md b/tests/testthat/_snaps/stats-htest.md
@@ -1,3 +1,10 @@
+# tidy.htest/oneway.test
+
+    Code
+      td <- tidy(ot)
+    Message
+      Multiple parameters; naming those columns num.df, den.df
+
 # augment.htest (chi squared test)
 
     Code

diff --git a/tests/testthat/test-ergm.R b/tests/testthat/test-ergm.R
@@ -51,10 +51,8 @@ test_that("tidy.ergm", {
 test_that("glance.ergm", {
   gl <- glance(gest, deviance = TRUE)
   gl2 <- glance(gest3, deviance = TRUE, mcmc = TRUE)
-  expect_message(
-    gl3 <- glance(gest, deviance = TRUE, mcmc = TRUE)
-  )
-
+  expect_snapshot(gl3 <- glance(gest, deviance = TRUE, mcmc = TRUE))
+
   check_glance_outputs(gl)
   check_dims(gl, expected_cols = 9)
   check_dims(gl2, expected_cols = 12)

diff --git a/tests/testthat/test-stats-htest.R b/tests/testthat/test-stats-htest.R
@@ -20,7 +20,7 @@ test_that("tidy.htest same as glance.htest", {
 test_that("tidy.htest/oneway.test", {
   mtcars$cyl <- as.factor(mtcars$cyl)
   ot <- oneway.test(mpg ~ cyl, mtcars)
-  expect_message(td <- tidy(ot))
+  expect_snapshot(td <- tidy(ot))
   gl <- glance(ot)
 
   check_tidy_output(td)